This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(prover): tie capacity to a specific block id #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
approved these changes
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 50.72% 50.44% -0.29%
==========================================
Files 39 39
Lines 4962 5000 +38
==========================================
+ Hits 2517 2522 +5
- Misses 2189 2223 +34
+ Partials 256 255 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capacity can be released twice if, when submitting a proof, the block becomes verified by someone else (ie: you were just too late to submit).
Because there are too many edge cases with arbitrary capacity, it should be tied to a block ID, and only be able to be released once for a given block.